Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move hash bin helpers from internal/targets to pkg/targets #244

Merged
merged 1 commit into from
Mar 28, 2022
Merged

Move hash bin helpers from internal/targets to pkg/targets #244

merged 1 commit into from
Mar 28, 2022

Conversation

ethan-lowman-dd
Copy link
Contributor

Release Notes:

  • Expose delegated targets role hash bin helpers as public APIs

Types of changes:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of the changes being introduced by the pull request:
Move hash bin helpers from internal/targets to pkg/targets

Please verify and check that the pull request fulfills the following requirements:

  • Tests have been added for the bug fix or new feature
  • Docs have been added for the bug fix or new feature

@coveralls
Copy link

coveralls commented Mar 27, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2048663738

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.277%
Totals Coverage Status
Change from base Build 2029695489: 0.0%
Covered Lines: 2278
Relevant Lines: 3196
💛 - Coveralls

@ethan-lowman-dd ethan-lowman-dd mentioned this pull request Mar 27, 2022
Closed
joshuagl
joshuagl approved these changes Mar 28, 2022
View reviewed changes
Copy link
Member

@joshuagl joshuagl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we found the similar functionality in python-tuf is useful as public API.

@ethan-lowman-dd ethan-lowman-dd merged commit 14b188b into master Mar 28, 2022
@ethan-lowman-dd ethan-lowman-dd deleted the ethan.lowman/expose-hash-bins branch March 28, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuagl joshuagl joshuagl approved these changes

@trishankatdatadog trishankatdatadog trishankatdatadog approved these changes

@asraa asraa Awaiting requested review from asraa

@mnm678 mnm678 Awaiting requested review from mnm678

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ethan-lowman-dd @coveralls @joshuagl @trishankatdatadog