fix: golangci-lint failures when tested against Go 1.20 #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Radoslav Dimitrov <dimitrovr@vmware.com>
trishankatdatadog
approved these changes
Feb 7, 2023
znewman01
approved these changes
Feb 7, 2023
znewman01
pushed a commit
to znewman01/go-tuf
that referenced
this pull request
May 22, 2023
…mework#457) fix: golangci-lint failed when tested against Go 1.20 Signed-off-by: Radoslav Dimitrov <dimitrovr@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following PR fixes the CI issues around Go 1.20 by updating the version of golangci-lint. It also removes the unnecessary version pin in its config file.
The reason this has to be done manually is Dependabot takes care of updating the action, but the golangci-lint version has to be manually pinned because of our testing scenarios. For reference - https://github.com/golangci/golangci-lint-action/blob/6a290f7d5d488e1e423b0b37fe802c822ca2c08c/README.md?plain=1#L108
Signed-off-by: Radoslav Dimitrov dimitrovr@vmware.com
Please fill in the fields below to submit a pull request. The more information that is provided, the better.
Fixes #455
Related to #454
Release Notes:
Types of changes:
!, as infeat!: change foo).Description of the changes being introduced by the pull request:
Please verify and check that the pull request fulfills the following requirements: