-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: Start linting tests #1582
Comments
Splitting tests across multiple directories may make sense, but I think the right combination of simple and not prone to error is a list of files excluded from lint? That way, new test files are linted and there's no ambiguity about where to place new tests. Also, the no-lint list gets shorter as we replace/remove existing tests. |
I notice I did not explicitly state this: we currently have lint files/directories listed in multiple places in tox.ini and then in setup.cfg for static type checking with mypy |
I think I will experiment by renaming all old test files with |
Can we use a prefix instead of a suffix so the files appear sorted in a way? |
I thought about adding a suffix instead of a prefix as the filenames will be easier to read. |
I expect prefixes would make more sense, if files need to be mass-renamed |
Another reasonable solution seems to move the old files in a separate folder, but if we move them won't we lose the git history? |
I read the GIT FAQ on this matter https://git.wiki.kernel.org/index.php/GitFaq#Why_does_Git_not_.22track.22_renames.3F and found out that both renames and file relocations will cause the git history to be lost. |
I will remove this issue from Sprint 11 for now as it contains multiple action items each of which requires a review. |
TODO items left to close this issue:
|
I believe we should enable linting (
tox -e lint
) for new test files (maybe even for some recent additions). Possibly some exceptions are needed but in general I think the tests would be better if they were linted.Good start for this would be test_updater_with_simulator.py and repository_simulator.py: it's new code and files are small so the changes are easy -- the real job is figuring out how to select what to lint... Possible options:
The text was updated successfully, but these errors were encountered: