Apply black on tests #1623
Closed
Apply black on tests #1623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we are using 4 tools: black, pylint, isort and mypy. We want to run all 4 of them on our tests for the new codebase to make it more readable and maintainable, but we don't want to run it on the old test files as they are following the old style guidelines. In order to achieve that we want to use an exclusion list instead of an inclusion list as the new code base will be developed in the future and new test files will appear. On another hand, we don't expect any more additional test files against the old code, so this list is static. I decided to hardcode the names we want to exclude because that way we won't have to remove the Git history, as opposed to renaming or moving the old test files. Even though the list is big around 30 files, I think this solution is fine as this list will only contain files testing the old code meaning the list will have static content. I will apply each of the linters in a separate pr. Signed-off-by: Martin Vrachev <mvrachev@vmware.com>
All of the changes included are a result of applying black on our tests on the new code. Signed-off-by: Martin Vrachev <mvrachev@vmware.com>
Signed-off-by: Martin Vrachev <mvrachev@vmware.com>
|
After researching the only solution I found to exclude specific tests was to introduce a new config file |
Pull Request Test Coverage Report for Build 1354989188
💛 - Coveralls |
|
Replaced by #1624. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #1582
Description of the changes being introduced by the pull request:
Currently, we are using 4 tools:
black,pylint,isortandmypy.We want to run all 4 of them on our tests for the new codebase to make
it more readable and maintainable, but we don't want to run it on the
old test files as they are following the old style guidelines.
In order to achieve that we want to use an exclusion list instead of
an inclusion list as the new code base will be developed in the future
and new test files will appear. On another hand, we don't expect any
more additional test files against the old code, so this list is static.
I decided to hardcode the names we want to exclude because that way we
won't have to remove the Git history, as opposed to renaming or moving
the old test files.
Even though the list is big around 30 files, I think this solution is
fine as this list will only contain files testing the old code meaning
the list will have static content.
I will apply each of the linters in a separate pr.