-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lock the repository if update / download running #369
Comments
This is something we are leaving up to the repository developers. Yes, On Mon, Aug 29, 2016 at 12:09 PM, Julian Hille notifications@github.com
|
I thought it would just be very easy to add a flock to "the_repository_dir/.lock" with an configurable time_delta when to reclaim the lock if a process before may have been killed or cancelled and the flock file still exists. |
At least we should add a note to the readme that concurrent processes may harm the repo and that the lock is up to the repository maintainer? Just for completeness im talking about the update client :> |
Ah, sure. We should update the docs in both the client and repository to make this clear. @vladimir-v-diaz: can you take a look at this and ensure this is clear? |
This is connected to #49 |
#972 added an explanation of this limitation to the readme. |
The repository should be locked while updating so that not two concurrent processes do not change it at the same time.
The text was updated successfully, but these errors were encountered: