Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove crypto functions already available in library dependency #656

Closed
vladimir-v-diaz opened this issue Mar 22, 2018 · 7 comments · Fixed by #919
Closed

Remove crypto functions already available in library dependency #656

vladimir-v-diaz opened this issue Mar 22, 2018 · 7 comments · Fixed by #919
Labels
good first issue Bite-sized items for first time contributors

Comments

@vladimir-v-diaz
Copy link
Contributor

Description of issue:

Some crypto functions implemented in TUF are duplicates of functions available in securesystemslib.

Current behavior:

For example, generate_and_write_rsa_keypair() is also provided by securesystemslib's equivalent.

Expected behavior:

The TUF library should replace all crypto functions that are already available in securesystemlib.

@vladimir-v-diaz vladimir-v-diaz added the good first issue Bite-sized items for first time contributors label Mar 22, 2018
@Skchoudhary
Copy link

Hi @vladimir-v-diaz, I would like to work on this issue.Can you guide me which methods/file to look.

@awwad
Copy link
Contributor

awwad commented Oct 3, 2018

There's an example in the description.

@vladimir-v-diaz
Copy link
Contributor Author

Thanks for the interest, @Skchoudhary. You would essentially replace the crypto functions in repository_lib.py that are duplicated in SSLib's interface.py.

@awwad will be able to confirm the specific functions that you are thinking of replacing. A pull request will make it easier for him to give you feedback.

@mallenjr
Copy link

Has this issue been resolved? I am looking at the code in the file mentioned above and from what I can tell the functions have all been converted over to the functions that are available in securesystemslib.

@tobithegreat
Copy link

Hello! It seems like this issue hasn't been resolved yet. I'd like to submit a pull request if that's alright.

@joshuagl
Copy link
Member

joshuagl commented Sep 12, 2019

I think this issue was resolved by PR #460? Or is it preferable to go one step further and remove the tuf methods which simply wrap functionality in securesystemslib? Such as import_ed25519_publickey_from_file()?

@lukpueh
Copy link
Member

lukpueh commented Sep 12, 2019

It looks like (pending) #804 also made some contributions there. I'll go ahead and review it.

Regarding you question, @joshuagl, I think (for now) we want to keep the wrappers to not change TUFs interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Bite-sized items for first time contributors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants