Lukpueh fix #412 #460
Merged
Lukpueh fix #412 #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
securesystemslib.interface copies functions to generate and import keys from repository_lib. This commit replaces those function implementations with calls to securesystemslib. Removes internal _prompt and _get_password from repository_lib because they were only used by the removed function bodies and also exist in securesystemslib.interface
Updates requirements.txt and setup.py requirements to point to a securesystemslib branch that updates key generate and import functions to return a key object with the optional keyid_hash_algorithms field. This references have to be updated once lukpueh:update-import-keys is merged into securesystemslib's master.
Use securesystemslib v0.10.5 dependency (includes Lukas' contributions and a fix). Add blank line between function docstring and beginning of code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor edits to #422. Fixes #412.