Improve error message and docstring for custom parameter in add_target()
#1027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change CUSTOM_SCHEMA to a dictionary mapping AnyString to Any value. This makes error reporting more indicative of what the expected value is, by reporting something like: FormatError: Expected a dict but got ‘meta’ instead of: FormatError: Expected a object but got 'meta' Signed-off-by: Joshua Lock <jlock@vmware.com>
Update the docstring to make it clear that 'custom' and 'fileinfo' are mutually exclusive, and further that the 'custom' parameter will be dropped in a future release. Signed-off-by: Joshua Lock <jlock@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please fill in the fields below to submit a pull request. The more information
that is provided, the better.
Fixes issue #: N/A
Description of the changes being introduced by the pull request:
add_target()to make the use of custom and fileinfo, that they are mutually exclusive and that we intend to deprecate custom much clearer.Please verify and check that the pull request fulfills the following
requirements: