Each key applies to signature threshold once #1091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit ensures that each key will only count toward the signature threshold once, even if the keys have different keyids. Signed-off-by: marinamoore <mmoore32@calpoly.edu>
mnm678
force-pushed
the
check-key-uniqueness
branch
from
00f101d
to
ae54c85
Compare
trishankatdatadog
approved these changes
Aug 3, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses part 2 of #1084.
This pr ensures that each key will only count toward the signature threshold once, even if the keys have different keyids. This will be especially important when repositories are allowed to define their own keyids as part of TAP 12.
The solution is based on @lukpueh's commit for threshold verification