Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve updater and tests logging #1092

Merged
merged 2 commits into from
Jul 30, 2020
Merged

Improve updater and tests logging #1092

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a9b7a6
Add NullHandler() to the top-level logger
sechkova Jul 29, 2020
963ed79
Replace logging.exception calls in Updater()
sechkova Jul 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tuf/client/updater.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1151,12 +1151,12 @@ def neither_403_nor_404(mirror_error):
# Otherwise, reraise the error, because it is not a simple HTTP
# error.
if neither_403_nor_404(mirror_error):
logging.exception('Misc error for root version '+str(next_version))
logger.exception('Misc error for root version '+str(next_version))
trishankatdatadog marked this conversation as resolved.
Show resolved Hide resolved
raise
else:
# Calling this function should give us a detailed stack trace
# including an HTTP error code, if any.
logging.exception('HTTP error for root version '+str(next_version))
logger.exception('HTTP error for root version '+str(next_version))
# If we are here, then we ran into only 403 / 404 errors, which are
# good reasons to suspect that the next root metadata file does not
# exist.
Expand Down