WIP: Remove slow retrieval attacks #1156
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Lock <jlock@vmware.com>
joshuagl
changed the title
Closed
3 tasks
MVrachev
added a commit
to MVrachev/tuf
that referenced
this pull request
Oct 19, 2020
Slow retrievals have been removed from the specification and soon it will be removed from the tuf reference implementation as a whole. This means that the chances of making this test useful are close to 0 if not none. For reference: - theupdateframework/specification#111 - theupdateframework#1156 Signed-off-by: Martin Vrachev <mvrachev@vmware.com>
MVrachev
added a commit
to MVrachev/tuf
that referenced
this pull request
Oct 19, 2020
Slow retrievals have been removed from the specification and soon it will be removed from the tuf reference implementation as a whole. This means that the chances of making this test useful are close to 0 if not none. For reference: - theupdateframework/specification#111 - theupdateframework#1156 Signed-off-by: Martin Vrachev <mvrachev@vmware.com>
MVrachev
added a commit
to MVrachev/tuf
that referenced
this pull request
Oct 22, 2020
Remove the test with mode 2 ('mode_2': During the download process,
the server blocks the download by sending just several characters
every few seconds.) from test_slow_retrieval.
This test is marked as "expected failure" with the purpose of
rewriting it one day, but slow retrievals have been removed from
the specification and soon it will be removed from the tuf
reference implementation as a whole.
That means that the chances of making this test useful are close
to 0 if not none.
The other test (with mode 1) in test_slow_retrieval is not removed.
For reference:
- theupdateframework/specification#111
- theupdateframework#1156
Signed-off-by: Martin Vrachev <mvrachev@vmware.com>
MVrachev
added a commit
to MVrachev/tuf
that referenced
this pull request
Oct 22, 2020
Remove the test with mode 2 ('mode_2': During the download process,
the server blocks the download by sending just several characters
every few seconds.) from test_slow_retrieval.
This test is marked as "expected failure" with the purpose of
rewriting it one day, but slow retrievals have been removed from
the specification and soon it will be removed from the tuf
reference implementation as a whole.
That means that the chances of making this test useful are close
to 0 if not none.
The other test (with mode 1) in test_slow_retrieval is not removed.
For reference:
- theupdateframework/specification#111
- theupdateframework#1156
Signed-off-by: Martin Vrachev <mvrachev@vmware.com>
MVrachev
added a commit
to MVrachev/tuf
that referenced
this pull request
Oct 28, 2020
Remove the test with mode 2 ('mode_2': During the download process,
the server blocks the download by sending just several characters
every few seconds.) from test_slow_retrieval.
This test is marked as "expected failure" with the purpose of
rewriting it one day, but slow retrievals have been removed from
the specification and soon it will be removed from the tuf
reference implementation as a whole.
That means that the chances of making this test useful are close
to 0 if not none.
The other test (with mode 1) in test_slow_retrieval is not removed.
For reference:
- theupdateframework/specification#111
- theupdateframework#1156
Signed-off-by: Martin Vrachev <mvrachev@vmware.com>
MVrachev
added a commit
to MVrachev/tuf
that referenced
this pull request
Oct 28, 2020
Remove the test with mode 2 ('mode_2': During the download process,
the server blocks the download by sending just several characters
every few seconds.) from test_slow_retrieval.
This test is marked as "expected failure" with the purpose of
rewriting it one day, but slow retrievals have been removed from
the specification and soon it will be removed from the tuf
reference implementation as a whole.
That means that the chances of making this test useful are close
to 0 if not none.
The other test (with mode 1) in test_slow_retrieval is not removed.
For reference:
- theupdateframework/specification#111
- theupdateframework#1156
Signed-off-by: Martin Vrachev <mvrachev@vmware.com>
MVrachev
added a commit
to MVrachev/tuf
that referenced
this pull request
Oct 28, 2020
Remove the test with mode 2 ('mode_2': During the download process,
the server blocks the download by sending just several characters
every few seconds.) from test_slow_retrieval.
This test is marked as "expected failure" with the purpose of
rewriting it one day, but slow retrievals have been removed from
the specification and soon it will be removed from the tuf
reference implementation as a whole.
That means that the chances of making this test useful are close
to 0 if not none.
The other test (with mode 1) in test_slow_retrieval is not removed.
For reference:
- theupdateframework/specification#111
- theupdateframework#1156
Signed-off-by: Martin Vrachev <mvrachev@vmware.com>
MVrachev
added a commit
to MVrachev/tuf
that referenced
this pull request
Nov 3, 2020
Remove the test with mode 2 ('mode_2': During the download process,
the server blocks the download by sending just several characters
every few seconds.) from test_slow_retrieval.
This test is marked as "expected failure" with the purpose of
rewriting it one day, but slow retrievals have been removed from
the specification and soon it will be removed from the tuf
reference implementation as a whole.
That means that the chances of making this test useful are close
to 0 if not none.
The other test (with mode 1) in test_slow_retrieval is not removed.
For reference:
- theupdateframework/specification#111
- theupdateframework#1156
Signed-off-by: Martin Vrachev <mvrachev@vmware.com>
MVrachev
added a commit
to MVrachev/tuf
that referenced
this pull request
Nov 4, 2020
Remove the test with mode 2 ('mode_2': During the download process,
the server blocks the download by sending just several characters
every few seconds.) from test_slow_retrieval.
This test is marked as "expected failure" with the purpose of
rewriting it one day, but slow retrievals have been removed from
the specification and soon it will be removed from the tuf
reference implementation as a whole.
That means that the chances of making this test useful are close
to 0 if not none.
The other test (with mode 1) in test_slow_retrieval is not removed.
For reference:
- theupdateframework/specification#111
- theupdateframework#1156
Signed-off-by: Martin Vrachev <mvrachev@vmware.com>
MVrachev
added a commit
to MVrachev/tuf
that referenced
this pull request
Nov 11, 2020
Remove the test with mode 2 ('mode_2': During the download process,
the server blocks the download by sending just several characters
every few seconds.) from test_slow_retrieval.
This test is marked as "expected failure" with the purpose of
rewriting it one day, but slow retrievals have been removed from
the specification and soon it will be removed from the tuf
reference implementation as a whole.
That means that the chances of making this test useful are close
to 0 if not none.
The other test (with mode 1) in test_slow_retrieval is not removed.
For reference:
- theupdateframework/specification#111
- theupdateframework#1156
Signed-off-by: Martin Vrachev <mvrachev@vmware.com>
MVrachev
added a commit
to MVrachev/tuf
that referenced
this pull request
Nov 13, 2020
Remove the test with mode 2 ('mode_2': During the download process,
the server blocks the download by sending just several characters
every few seconds.) from test_slow_retrieval.
This test is marked as "expected failure" with the purpose of
rewriting it one day, but slow retrievals have been removed from
the specification and soon it will be removed from the tuf
reference implementation as a whole.
That means that the chances of making this test useful are close
to 0 if not none.
The other test (with mode 1) in test_slow_retrieval is not removed.
For reference:
- theupdateframework/specification#111
- theupdateframework#1156
Signed-off-by: Martin Vrachev <mvrachev@vmware.com>
MVrachev
added a commit
to MVrachev/tuf
that referenced
this pull request
Nov 13, 2020
Remove the test with mode 2 ('mode_2': During the download process,
the server blocks the download by sending just several characters
every few seconds.) from test_slow_retrieval.
This test is marked as "expected failure" with the purpose of
rewriting it one day, but slow retrievals have been removed from
the specification and soon it will be removed from the tuf
reference implementation as a whole.
That means that the chances of making this test useful are close
to 0 if not none.
The other test (with mode 1) in test_slow_retrieval is not removed.
For reference:
- theupdateframework/specification#111
- theupdateframework#1156
Signed-off-by: Martin Vrachev <mvrachev@vmware.com>
|
I'm closing this as I don't think it makes sense to remove a feature from the current codebase at this time. Instead, let's plan to not include slow retrieval in the refactor until we have better ideas about how to specify the feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please fill in the fields below to submit a pull request. The more information
that is provided, the better.
Fixes issue #:
Description of the changes being introduced by the pull request:
Slow retrievals have been removed from the specification, update the reference implementation accordingly.
Please verify and check that the pull request fulfills the following
requirements: