Make metadata signatures ordered by keyid #1217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 'repository_lib._generate_and_write_metadata' sort the set of signing key keyids alphabetically before passing them on to signing functions, to make the order in which signatures are added deterministic. This is above all beneficial for testing. This commit also adds an exemplary test for signatures on root metadata using the repository_tool interface to setup all the state that required to test _generate_and_write_metadata. Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
mnm678
approved these changes
Nov 20, 2020
jku
approved these changes
Nov 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1154 and parts of #1211.
Description of the changes being introduced by the pull request:
In
repository_lib._generate_and_write_metadatasort the set of signing key keyids alphabetically before passing them on to signing functions, to make the order in which signatures are added deterministic. This is above all beneficial for testing.This commit also adds an exemplary test for signatures on root metadata using the
repository_toolinterface to setup all the state that is required to test _generate_and_write_metadata.Kudos to @erickt for proposing this fix, and to him and @davidstrauss for bringing the issue to our attention.
Please verify and check that the pull request fulfills the following
requirements: