Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Lint install_requires in setup.py #1295

Merged

Conversation

rzr
Copy link
Contributor

@rzr rzr commented Mar 2, 2021

While doing packaging works I noticed that
pypi file 'tuf.egg-info/requires.txt' was modified on build.

Let's sort dependencies alphabetically to avoid lint to change sources files.

Change-Id: I009810877681afe9b84a3c4f9bed14553327105b
Signed-off-by: Philippe Coval rzr@users.sf.net

Please fill in the fields below to submit a pull request. The more information
that is provided, the better.

Fixes #

Description of the changes being introduced by the pull request:

Please verify and check that the pull request fulfills the following
requirements
:

  • The code follows the Code Style Guidelines
  • Tests have been added for the bug fix or new feature
  • Docs have been added for the bug fix or new feature

@jku
Copy link
Member

jku commented Mar 3, 2021

Sounds good to me but which linter is this? something debian build tooling runs automatically?

@rzr
Copy link
Contributor Author

rzr commented Mar 3, 2021

Yes "egg_info" does the linting and update the file.

I can explain how to replicate

git clone https://github.com/CrossStream/tuf 
cd tuf
git checkout -b upstream origin/upstream
git checkout -b debian/master origin/debian/master
uscan --download-current
gbp buildpackage
# (...)
# running install_egg_info
# running egg_info
# writing tuf.egg-info/PKG-INFO
# writing dependency_links to tuf.egg-info/dependency_links.txt
# writing requirements to tuf.egg-info/requires.txt
# (...)
git diff
diff --git a/tuf.egg-info/requires.txt b/tuf.egg-info/requires.txt
index 319b2b54..26ed815a 100644
--- a/tuf.egg-info/requires.txt
+++ b/tuf.egg-info/requires.txt
@@ -1,3 +1,3 @@
 requests>=2.19.1
-six>=1.11.0
 securesystemslib>=0.18.0
+six>=1.11.0

@joshuagl
Copy link
Member

joshuagl commented Mar 3, 2021

Thank you for the contribution @rzr

Change-Id: I009810877681afe9b84a3c4f9bed14553327105b

Could you remove this from your commit messages?

While doing packaging works I noticed that
pypi file 'tuf.egg-info/requires.txt' was modified on build.

Let's sort dependencies alphabetically
to avoid lint to change sources files.

Signed-off-by: Philippe Coval <rzr@users.sf.net>
@rzr rzr force-pushed the sandbox/rzr/build/review/master branch from 5efcece to 6b89f18 Compare March 3, 2021 12:14
@jku jku merged commit 801c5e3 into theupdateframework:develop Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants