Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tox: Don't use pre-release tools #1364

Merged
merged 1 commit into from
May 5, 2021

Conversation

jku
Copy link
Member

@jku jku commented Apr 27, 2021

Keep using newest versions of build tools, but don't use pre-releases:

  • less downloading (with chances of failures) happens in the CI because
    versions change less often
  • tools are less likely to break the build (or at least it happens less
    often)

This change should not affect the software under test as we install
pinned versions of those.

Note that this also doesn't affect black: tox still ends up with a
pre-release version of black because that project has never made an
actual release.

Fixes #1350

Signed-off-by: Jussi Kukkonen jkukkonen@vmware.com

Keep using newest versions of build tools, but don't use pre-releases:
* less downloading (with chances of failures) happens in the CI because
  versions change less often
* tools are less likely to break the build (or at least it happens less
  often)

This change should not affect the software under test as we install
pinned versions of those.

Note that this also doesn't affect black: tox still ends up with a
pre-release version of black because that project has never made an
actual release.

Fixes theupdateframework#1350

Signed-off-by: Jussi Kukkonen <jkukkonen@vmware.com>
Copy link
Member

@joshuagl joshuagl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@jku jku merged commit 28e420b into theupdateframework:develop May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Let's not use pre-release versions of tools in tox environments
2 participants