Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Allow failure when publishing on coveralls #1369

Merged
merged 1 commit into from
May 4, 2021

Conversation

sechkova
Copy link
Contributor

Description of the changes being introduced by the pull request:

A failure during publishing of the coverage results on coveralls should not fail the whole build job.
Allow the step to fail.

A side effect of this change is that failures in this step will be unnoticed by PR authors unless intentionally looking at the CI run log.

Please verify and check that the pull request fulfills the following
requirements
:

  • The code follows the Code Style Guidelines
  • Tests have been added for the bug fix or new feature
  • Docs have been added for the bug fix or new feature

A failure during publishing of the coverage results
on coveralls should not fail the whole build job.
Allow the step to fail.

Signed-off-by: Teodora Sechkova <tsechkova@vmware.com>
Copy link
Member

@jku jku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed: Noticing a 500-error from Coverage is less important than reliable testing on CI (this is IIRC the same setup we had on travis)

@jku jku merged commit b22659e into theupdateframework:develop May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants