Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata API: Add Key attributes types validation #1449

Merged
merged 2 commits into from
Jun 16, 2021

Commits on Jun 15, 2021

  1. Metadata API: Add Key attributes types validation

    In our discussion with Jussi we come to the conclusion that we want
    to verify that all Key attributes contain values in the expected types,
    but at the same time, we don't want to focus on validating the semantics
    behind them.
    The reason is that having a Key instance with invalid attributes is
    possible and supported by the spec.
    That's why we have a "threshold" for the roles meaning we can have up to
    a certain number of invalid Keys until we satisfy
    the required threshold.
    
    Also, for deeper semantic validation it's better to be done in
    securesystemslib which does the actual work with keys.
    
    For context see: theupdateframework#1438
    
    Signed-off-by: Martin Vrachev <mvrachev@vmware.com>
    MVrachev committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    f20664d View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2021

  1. Metadata API: Add a comment for Key validation

    Clarify that we don't semantically validate "Key" instances during
    initialization and that this is a responsibility of securesystemslib.
    
    Signed-off-by: Martin Vrachev <mvrachev@vmware.com>
    MVrachev committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    a9dc24a View commit details
    Browse the repository at this point in the history