Metadata API: add Metadata.to_bytes() #1490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
joshuagl
reviewed
Jul 13, 2021
MVrachev
force-pushed
the
metadata-to-bytes
branch
2 times, most recently
from
ffc37b6
to
af4329b
Compare
|
I updated the pr so that |
jku
reviewed
Jul 15, 2021
Metadata.to_bytes() is missing from the API and that is now becoming annoying when writing the tests. I think it makes sense to add: it'll complete the serializing counterparts to from_bytes()/from_file(). We can also reuse to_bytes() in to_file() and that way ensure we don't import the JSONSerializer locally twice. Signed-off-by: Martin Vrachev <mvrachev@vmware.com>
MVrachev
force-pushed
the
metadata-to-bytes
branch
from
af4329b
to
4f37de1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1487
Description of the changes being introduced by the pull request:
Metadata.to_bytes() is missing from the API and that is now becoming
annoying when writing the tests.
I think it makes sense to add:
it'll complete the serializing counterparts to from_bytes()/from_file().
Signed-off-by: Martin Vrachev mvrachev@vmware.com
Please verify and check that the pull request fulfills the following
requirements: