tests: Add target support to RepositorySimulator #1587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MVrachev
approved these changes
Sep 21, 2021
MVrachev
reviewed
Sep 23, 2021
sechkova
reviewed
Sep 23, 2021
jku
force-pushed
the
tests-repo-sim-targets-support
branch
from
99c028c
to
c333ca6
Compare
Pull Request Test Coverage Report for Build 1269142426Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
added 2 commits
September 24, 2021 13:41
* Add very simple targets support into simulator * Add documentation for the simulator * Add an example targets test This might need to be tweaked and/or extended as we add tests but the implementation should give a good indication of how to extend it. As an example, non-consistent targets are not yet supported, but making fetch() check for the consistent_snapshot state and respond accordingly should be easy. Signed-off-by: Jussi Kukkonen <jkukkonen@vmware.com>
The handling of consistent snapshot was not very clear: try to make it more obvious what is supported and what is not. Signed-off-by: Jussi Kukkonen <jkukkonen@vmware.com>
jku
force-pushed
the
tests-repo-sim-targets-support
branch
from
c333ca6
to
59b0b99
Compare
|
Modified based on feedback, rebased on develop |
sechkova
approved these changes
Sep 24, 2021
MVrachev
approved these changes
Sep 24, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might need to be tweaked and/or extended as we add tests but the
implementation should give a good indication of how to extend it.
As an example, non-consistent targets (or metadata) are not yet supported, but
making fetch() check for the consistent_snapshot state and respond
accordingly should be easy.
Signed-off-by: Jussi Kukkonen jkukkonen@vmware.com
This should be useful to properly test consistent targets (#1576 ) and then implement good test coverage for updater in general.
CC @MVrachev, marking you a reviewer as I know you might want to use it. If you have any improvement ideas let me know. A potential one is a way for simulator to verify targets client has downloaded (a helper, so tests could say "assert that my target is correct"), but I figured we'd first write some tests and see where we duplicate code...