test timestamp fast-forward attack recovery #1735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1602865766
💛 - Coveralls |
jku
reviewed
Dec 20, 2021
jku
approved these changes
Dec 20, 2021
There was a problem hiding this comment.
LGTM, the only nitpicks I have are
- the docstring doesn't specify that timestamp rollback requires timestamp key rotation (this is relevant because the snapshot rollback requires rotating both online keys and not everyone knows these differences) ... but the code does make it clear
- PR is marked as fixing the issue but it only fixes 1/3 (as mentioned snapshot and targets are slightly different cases)
Anyway, I think we can merge this as is, those are really minor. If you do tweak the docstring, feel free to squash to a single commit.
This test simulates the timestamp fast-forward attack recovery. It simulates that the timestamp keys were compromised, the attacker generated a new high version of the timestamp. The repository generates a new key and rollbacks the timestamp version to the initial version. Signed-off-by: Kairo de Araujo <kdearaujo@vmware.com>
kairoaraujo
force-pushed
the
issue#1713/test_fast-forward_recovery
branch
from
e5c5b96
to
76a3e6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test simulates the timestamp fast-forward attack recovery.
It simulates that the timestamp keys were compromised, the attacker
generated a new high version of the timestamp.
The repository generates a new key and rollbacks the timestamp
version to the initial version.
Signed-off-by: Kairo de Araujo kdearaujo@vmware.com
Please fill in the fields below to submit a pull request. The more information
that is provided, the better.
Part of #1713