Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify checking for freeze attacks on the root metadata file. #452

Merged
merged 3 commits into from
Jun 19, 2017
Merged

Clarify checking for freeze attacks on the root metadata file. #452

merged 3 commits into from
Jun 19, 2017

Conversation

trishankkarthik
Copy link
Contributor

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.936% when pulling 13cfa2e on trishankkarthik:add-detailed-workflow into c1e72e0 on theupdateframework:develop.

@@ -970,11 +970,17 @@ Version 1.0 (Draft)
1.5. **Check for a freeze attack.** The latest known time should be lower
than the expiration timestamp in the current root metadata file.

1.5. Note that the expiration of the current (intermediate) root metadata

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate item 1.5

@vladimir-v-diaz vladimir-v-diaz self-requested a review June 19, 2017 16:17
Copy link
Contributor

@vladimir-v-diaz vladimir-v-diaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although the original text seemed clear enough to @heartsucker (according to theupdateframework/rust-tuf#49 (comment)), I think this is a good change. It is more clear to me why checking Root's expiration should be done once the latest version is reached.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.3%) to 97.904% when pulling a44551b on trishankkarthik:add-detailed-workflow into ee770da on theupdateframework:develop.

@vladimir-v-diaz vladimir-v-diaz merged commit 0f40e70 into theupdateframework:develop Jun 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants