Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove example metadata and link to /tests metadata from METADATA.md #496

Conversation

vladimir-v-diaz
Copy link
Contributor

@vladimir-v-diaz vladimir-v-diaz commented Oct 11, 2017

Fixes issue #:
Addresses issue #436.

Description of the changes being introduced by the pull request:
The metadata used by the unit and integration tests are the most up-to-date. This pull request removes the duplicate metadata in /examples and retains the latest metadata available in tests/repository_data. The examples in METADATA.md now link to the metadata in tests/repository_data

Please note that the Trident modifications have not yet been merged into the "develop" branch. An implementation of the map file is awaiting a review in PR #430, and support for multi-role delegations is available in Uptane, however, it is based on an old TAP/design that will need changing before being merged into TUF.

Please verify and check that the pull request fulfills the following
requirements
:

  • The code follows the Code Style Guidelines
  • Tests have been added for the bug fix or new feature
  • Docs have been added for the bug fix or new feature

Instead of having duplicate metadata in examples/ and tests/repository_data, retain only the metadata in tests/repository_data and link to them from METADATA.md
@vladimir-v-diaz vladimir-v-diaz merged commit e5776b7 into theupdateframework:develop Oct 11, 2017
@coveralls
Copy link

coveralls commented Oct 11, 2017

Coverage Status

Coverage remained the same at 99.293% when pulling 2a0b86b on vladimir-v-diaz:remove_example_metadata into 9c9941e on theupdateframework:develop.

Copy link
Contributor

@awwad awwad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vladimir-v-diaz vladimir-v-diaz deleted the remove_example_metadata branch April 13, 2018 18:08
@joshuagl joshuagl mentioned this pull request Sep 12, 2019
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants