Move repository_lib.get_taget_hash back from sslib to tuf #909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function used to last be implemented in securesystemslib and repository_lib.get_taget_hash only served as wrapper. secure-systems-lab/securesystemslib#165 drops the function as TUF-specific. The used constant `securesystemslib.util.HASH_FUNCTION` is replaced with `tuf.settings.DEFAULT_HASH_ALGORITHM`, both of which default to 'sha256'. NOTE: repository_lib.get_taget_hash might be removed altogether in the future (see corresponding code comment). Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
lukpueh
added a commit
to secure-systems-lab/securesystemslib
that referenced
this pull request
Sep 5, 2019
Also remove now obsolete util.HASH_FUNCTION and corresponding tests. The function is added back to tuf in theupdateframework/python-tuf#909.
adityasaky
approved these changes
Sep 5, 2019
|
Thanks, @adityasaky! |
tanishqjasoria
pushed a commit
to tanishqjasoria/securesystemslib
that referenced
this pull request
Jan 30, 2020
Also remove now obsolete util.HASH_FUNCTION and corresponding tests. The function is added back to tuf in theupdateframework/python-tuf#909.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #:
Related to secure-systems-lab/securesystemslib#165
Description of the changes being introduced by the pull request:
The function used to last be implemented in securesystemslib and repository_lib.get_taget_hash only served as wrapper.
secure-systems-lab/securesystemslib#165 drops the function as TUF-specific.
The used constant
securesystemslib.util.HASH_FUNCTIONis replaced withtuf.settings.DEFAULT_HASH_ALGORITHM, both of which default to 'sha256'.NOTE: The function might be removed altogether in the future (see corresponding code comment).
Please verify and check that the pull request fulfills the following
requirements: