Rename pouf::Json to Pouf1 #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kellerb
approved these changes
Sep 28, 2022
After a discussion with the TUF community, we decided it made more sense to name our implementation of [POUF-1] as `Pouf1`, not `Json`, because it has additional restrictions on top of JSON. Furthermore, it doesn't make sense to call this [CJSON] since TUF doesn't allow for raw bytes in strings. This also moves `JsonPretty` into the interop-tests, since this is only used to make the interop tests easier to review. I've filed [161] with the TUF spec to consider allowing whitespace in POUF-1. If this is accepted we can move this back into the tuf::pouf submodule. [POUF-1]: https://github.com/theupdateframework/taps/blob/master/POUFs/reference-POUF/pouf1.md [161]: theupdateframework/taps#161 [CJSON]: https://wiki.laptop.org/go/Canonical_JSON
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a discussion with the TUF community, we decided it made more sense to name our implementation of POUF-1 as
Pouf1, notJson, because it has additional restrictions on top of JSON. Furthermore, it doesn't make sense to call this CJSON since TUF doesn't allow for raw bytes in strings.This also moves
JsonPrettyinto the interop-tests, since this is only used to make the interop tests easier to review. I've filed 161 with the TUF spec to consider allowing whitespace in POUF-1. If this is accepted we can move this back into the tuf::pouf submodule.