Clarify "paths" and "path_hash_prefixes" #158
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarify "paths" and "path_hash_prefixes" in delegations, because currently, it's not properly defined which of these options can be used to create a valid target file: - BOTH paths and path_hash_prefixes - ONLY ONE of paths and path_hash_prefixes - NONE of paths and path_hash_prefixes With this change, I aim to define clearly that a valid target file will contain ONLY ONE of them or NONE of them. Signed-off-by: Martin Vrachev <mvrachev@vmware.com>
joshuagl
reviewed
May 26, 2021
| <a>"path_hash_prefixes"</a> or <a for="delegation-role">"paths"</a> attributes, each of which we | ||
| discuss next. | ||
| The <a>"path_hash_prefixes"</a> and <a for="delegation-role">"paths"</a> | ||
| attributes are optional, if used, exactly one of them should be set. |
There was a problem hiding this comment.
Suggested change
| attributes are optional, if used, exactly one of them should be set. | |
| attributes are OPTIONAL, if used, exactly one of them should be set. |
We use RFC 2119 keywords in the spec.
|
Superseded by #165. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note!
The
Text Macro: VERSIONis bumped by two with the idea of merging #157 before this pr.Fixes: #156
Clarify "paths" and "path_hash_prefixes" in delegations, because
currently, it's not properly defined which of these options can be used
to create a valid target file:
With this change, I aim to define clearly that a valid target file will
contain ONLY ONE of them or NONE of them.
Signed-off-by: Martin Vrachev mvrachev@vmware.com