Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RepositorySimulator.add_key() only works for top level roles #126

Closed
jku opened this issue Aug 12, 2024 · 1 comment · Fixed by #129
Closed

RepositorySimulator.add_key() only works for top level roles #126

jku opened this issue Aug 12, 2024 · 1 comment · Fixed by #129
Labels
bug Something isn't working

Comments

@jku
Copy link
Member

jku commented Aug 12, 2024

def add_key(self, role: str)

this assumes the delegating role is root. That's a fine default but I want to add keys for non-top-level roles too

This should work:
def add_key(self, role: str, delegator: str | None)

(and then use Root.type as the real default value)

@jku
Copy link
Member Author

jku commented Aug 13, 2024

this is fixed in #129

@jku jku linked a pull request Aug 13, 2024 that will close this issue
@jku jku added the bug Something isn't working label Aug 13, 2024
@jku jku closed this as completed in #129 Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant