More cleanup, refactor some rollback tests #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling the downgrade_*() methods does not seem to do anything more than decrease the version (since the meta contents are already correct): do that instead. Add comments, docstrings and return value asserts. Remove a few update_timestamp() calls that do not seem valuable to the test. Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
* Remove unused methods * Make add_key() support delegating roles other than root * Rename add_target -> add_artifact (to make it clear this is artifacts and not targets the role Also remove unused simple_server.py Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
AdamKorcz
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RepositorySimulator.downgrade_*()methods: they don't seem to provide much valueadd_target()(to make it clear it's about artifacts, not metadata)add_key()so it supports other delegators