Add unusual rolename tests #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use "-vvv" to do debug logging. Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
We can't 100% know what filenames the client uses: so tests can't always ask "is this role trusted?" but have to look at whole list. Signed-off-by: Jussi Kukkonen <jkukkonen@google.�com>
Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
jku
commented
Aug 13, 2024
jku
commented
Aug 13, 2024
Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
This matches metadata_statstics in repository simulator. Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
I did not change the existing uses yet but I think trusted_roles() looks ok to me now -- it's the same as RepositorySimulator.metadata_statistics, except it's not sorted by time: mtime did not seem accurate enough since the files are written very quickly. So it is sorted by alpha. |
AdamKorcz
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests are useful in codifying some expectations on how to handle weird rolenames. I wouldn't be surprised if some clients want to skip this test but the
"../delegatedrole"case comes from an actual security issue we've had (file traversal when storing the metadata).This also enables #137 although I did not replace usage of
_file_exist()yet -- I'm not sure if the newtrusted_roles(self)is the right API?