This repository was archived by the owner on Jan 3, 2025. It is now read-only.
Show Minutes and Seconds in Cutoff #462
Merged
+131
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregorbg
reviewed
Feb 16, 2024
|
We currently do not have a strategy in place for sharing code. I would think an npm package using typescript would be the best idea. |
What about https://github.com/thewca/wca-helpers? |
gregorbg
reviewed
Feb 17, 2024
|
It does not. I'll add it now |
|
There is actually already a format centisecond method in wca-helpers https://github.com/thewca/wca-helpers/blob/master/src/helpers/time.ts, but it doesn't include the string. |
|
That's done thewca/wca-helpers#30 |
|
I'm going to merge this for now and then just make another PR when we update wca-helpers |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.