Split out editing venues from editing schedule #10028
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
both point to the same react component
not actually doing anything, as far as I can tell
since it doesn't exist anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The styling is a bit off with the "Venues + Add a venue" and the text at the top of each tab being a bit close to the content below (formerly there was an accordion).
Now each folder has an
indexand a (single) component subfolder with anotherindex, so it might be worth bringing those subfolder contents up and having a singleindex(maybe as a follow-up PR?).There's some minor duplication now, since everything was duplicated then trimmed away, mostly in the 2 top-level
indexfiles.I removed a scss file because it didn't appear to be doing anything, but I'm not 100% confident in this.