Show Registration status in comp overview page by default #10518
+54
−157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've added an attempt at providing cached registration status even in the default index, which should hopefully alleviate the burden on our DB |
|
Is this checkbox meant to be there twice? Besides that, front-end code looks good.
|
|
Thanks, that was obviously a merge whoopsie which I've fixed now. |
gregorbg
force-pushed
the
feature/comp-overview-reg-status-default
branch
from
f80c02c to
fa8cbd4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Promised follow-up to #10461
Only feature we're losing now is the "hydrated caching" in Redis. Registration values are now always pulled from the database freshly, and TBH I'm not sure whether that's a good thing.EDIT: We're still loosing the "fancy" version of the hydration, where it individually determines which key is cached and which one isn't, but otherwise we do get individually cached status entries now.