Untangle some threads (aka. clean up caching mechanisms with unnecessary thread_mattr_accessor) #9758
+142
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregorbg
force-pushed
the
cleanup/tc-caching
branch
2 times, most recently
from
5c56085
to
23fcc8d
Compare
(which at the time of writing this means everywhere)
gregorbg
force-pushed
the
cleanup/tc-caching
branch
from
23fcc8d
to
c85e161
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out we were a bit more careful than we needed to be when introducing strongly thread-safe attribute caches in #9681
The thread-safe accessors can make it so that all threads hold their own, local copies. But in most cases, we actually don't want the threads to hold their own local copies. For example, we don't want the cached 3x3 event to exist N times for N threads.
Further reading on why the GIL is helpful here: https://thoughtbot.com/blog/untangling-ruby-threads