Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ko translation. #9780

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

thewca-bot
Copy link
Contributor

Submitted by Ilkyoo Choi (최일규) (WCA ID: 2008CHOI04, WCA Account ID: 14).

✔️ This translation comes from a verified translator for this language.

@Ilkyoo
Copy link

Ilkyoo commented Aug 14, 2024

Why did this fail?

@dunkOnIT
Copy link
Contributor

Looks like there is a syntax error somewhere in the YAML file:
#<Psych::SyntaxError: (/home/runner/work/worldcubeassociation.org/worldcubeassociation.org/config/locales/ko.yml): did not find expected key while parsing a block mapping at line 1131 column 7> (I18n::InvalidLocaleData)

@gregorbg
Copy link
Member

FWIW, there are currently three open Korean translation PRs:

Judging by the line count (in the top right corner) they are all slightly different.
@Ilkyoo Could you please clarify which PR is the "correct" one? Then we will dive into debugging.

@Ilkyoo
Copy link

Ilkyoo commented Aug 15, 2024 via email

@gregorbg
Copy link
Member

Why did this fail?

I have now investigated the issue, and the YAML file that you submitted (= pasted into the WCA website input box) had some duplicate keys.

How did you generate the output that you submitted? Did you use Jonatan's Internationalization tool?

@Ilkyoo
Copy link

Ilkyoo commented Aug 16, 2024

So here is what happened:

#9374: I did a minor update on May 13, 2024 to fix [missing "ko.cutoff.time.one" translation].
I think I used Jonatan's internationalization tool, but maybe I just downloaded the file and didn't sync.

#9765: I did another 'minor' update on Aug 12, 2024, and I used Jonatan's Internationalization tool.
This time I did the sync, and was suggested(forced?) to do some additional translating.
I downloaded the resulting file and uploaded it.
Unexpectedly (for me at least), the update I did for #9374 were lost ([missing "ko.cutoff.time.one" translation] appeared again)

#9777, #9778, #9779, #9780
So I tried to start with the #9374 version of ko.yml, and manually added the translations I did for #9765 by looking at the diff file.

Every attempt I did failed :{

Help please?

@Ilkyoo
Copy link

Ilkyoo commented Aug 20, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants