Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip. still need to improve design #330

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

thewh1teagle
Copy link
Owner

Still need to work on the design

image

@oleole39
Copy link
Contributor

oleole39 commented Oct 9, 2024

Not sure if/where a check is/will be made to make sure the segment timing is consistent (i.e. start_time < end_time, end_time <= max_time, start_time >= 0), but if retrieving the file duration value is not too difficult, it could be displayed by default in the end_time input box (instead of 00:00:00) to make it look consistent (maybe the check box is even unecessary - i.e. when changing default settings of 00:00 to max_time it means the user wants to enable this feature)

@thewh1teagle
Copy link
Owner Author

Not sure if/where a check is/will be made to make sure the segment timing is consistent (i.e. start_time < end_time, end_time <= max_time, start_time >= 0), but if retrieving the file duration value is not too difficult, it could be displayed by default in the end_time input box (instead of 00:00:00) to make it look consistent (maybe the check box is even unecessary - i.e. when changing default settings of 00:00 to max_time it means the user wants to enable this feature)

Great idea! I can display the time range only once you select the audio file. then the checkbox is unecessary :)
We only need to make sure that time range is valid according to the audio.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants