Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Must be
oars-1.1
in order to have it as an empty XML tag.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Source?
I used the oars generator by hughsie.
The appstream-util considers this to be correct and many applications on Flathub use exactly the same empty tag:
https://github.com/flathub/com.bitwarden.desktop/blob/16ecfae90dffb072ca5d2ea3900cb34bf0a8c961/com.bitwarden.desktop.appdata.xml#L53
https://github.com/flathub/com.calibre_ebook.calibre/blob/b3bfed61a7ea49df185945ae3a5daa171baa9460/com.calibre_ebook.calibre.appdata.xml#L28
https://github.com/flathub/net.sourceforge.Teo/blob/ad6ea0dcf7e36eec1965388e357f4935cc4307a3/teo-7722f5749d52537b24808cd621a519f3d05b1e1a....patch#L6992
https://github.com/flathub/org.eclipse.iot.fourdiac.Ide/blob/df836bd8b481504f7c023fdf84ee2a3fa49ebce2/4diac-ide.appdata.xml#L22
https://github.com/flathub/space.fips.Fips/blob/30038cb77d9f258b5bc0f044b0986ab93f6f7cdb/space.fips.Fips.appdata.xml#L4
Even nedrichards confirmed that this is correct and he is Flathub maintainer.
flathub/flathub#525 (comment)
Anyway, if you think it's incorrect, you should report it to hugsie.