This repository has been archived by the owner on Aug 29, 2023. It is now read-only.
Usar rollup #34
Merged
Usar rollup #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thgmhz
suggested changes
Jul 15, 2017
There was a problem hiding this comment.
@thiamsantos Gostei bastante do rollup ele reduziu muito o build do browser!! Acho que está faltando apenas um detalhe pra finalizar o PR, eu comentei no review, repare que os testes estão falhando no travis. Vlw!
| @@ -1,7 +1,7 @@ | |||
| import auth from './auth' | |||
| import find from './find' | |||
|
|
|||
| module.exports = { | |||
| export { | |||
There was a problem hiding this comment.
@thiamsantos aqui precisa de export default, repare que os testes estão falhando por não encontrar os métodos auth e find.
There was a problem hiding this comment.
Já corrigi o problema. Agora o projeto adere completamente à sintaxe dos módulos ES6.
thgmhz
approved these changes
Jul 15, 2017
|
Maravilha! Ficou ótimo, valeu mesmo =) |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#33 O uso do rollup no lugar do browserify possibilita uma redução no tamanho do bundle. Vários projetos usam hoje o rollup inclusive o react. Vale a leitura desse artigo para mais informações.
Antes:
Depois:
Edit:
Remoção de comentário que não se aplica.