Skip to content

Commit

Permalink
fix comment
Browse files Browse the repository at this point in the history
  • Loading branch information
thheller committed Apr 24, 2024
1 parent b3e22da commit 236e357
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion src/main/shadow/build/npm.clj
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,11 @@
{:prefix path
:match match})

;; FIXME: are wildcards only allowed at end?
;; wildcards are allowed to appear at the end and with additional suffix
;; https://nodejs.org/api/packages.html#subpath-patterns
;; although webpack makes it appear its only allowed at the end
;; https://webpack.js.org/guides/package-exports/
;; leave :suffix nil if at the end, so later we know if that needs to be checked
(if-some [star-idx (str/index-of path "*")]
(update package :exports-wildcard util/vec-conj
;; strip * here, so we don't have to do it again later
Expand Down

0 comments on commit 236e357

Please sign in to comment.