Add a service restart parameter. #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thias Would you like me to make any changes to this to get it merged? |
|
It's been awhile but I'm picking up some DNS/Puppet work again. Any chance of getting this looked at/merged? |
anarcat
pushed a commit
to anarcat/puppet-bind
that referenced
this pull request
Nov 23, 2022
Automatic quote and unquote TXT and SPF
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a parameter for a service restart command.
One use case is using
named-checkconf -z /etc/named.conf && service named restartas the restart command to prevent the module from restarting BIND if there are syntax errors innamed.confor any of the zone filesnamed.confloads.The defaults are set to
service ${servicename} reload, which is what was hard-coded intomanifests/service.ppbefore.