[14.0][ADD] sale_order_*requested_delivery_period #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thienvh332
force-pushed
the
14.0-add-sale_order_import_delivery_period
branch
from
279994e to
4c013b2
Compare
thienvh332
force-pushed
the
14.0-add-sale_order_import_delivery_period
branch
from
4c013b2 to
a7604f3
Compare
thienvh332
force-pushed
the
14.0-add-sale_order_import_delivery_period
branch
from
a7604f3 to
ed9335c
Compare
thienvh332
changed the title
chaule97
reviewed
Aug 13, 2024
| wiz = self.env["sale.order.import"].create( | ||
| {"order_file": base64.b64encode(xml_file), "order_filename": filename} | ||
| ) | ||
| f.close() |
There was a problem hiding this comment.
Suggested change
| f.close() |
when run out with, f will be closed
chaule97
reviewed
Aug 13, 2024
| self.assertEqual(so.customer_order_number, res["client_order_ref"]) | ||
| self.assertEqual(so.customer_order_free_ref, "MrBlue") | ||
| self.assertEqual( | ||
| so.client_order_ref, res["client_order_ref"] + " - MrBlue" |
There was a problem hiding this comment.
Suggested change
| so.client_order_ref, res["client_order_ref"] + " - MrBlue" | |
| so.client_order_ref, res["client_order_ref"] + f" - {customer_reference}" |
| if res.get("client_order_ref"): | ||
|
|
||
| self.assertEqual(so.customer_order_number, res["client_order_ref"]) | ||
| self.assertEqual(so.customer_order_free_ref, "MrBlue") |
There was a problem hiding this comment.
Suggested change
| self.assertEqual(so.customer_order_free_ref, "MrBlue") | |
| self.assertEqual(so.customer_order_free_ref, customer_reference) |
| wiz = self.env["sale.order.import"].create( | ||
| {"order_file": base64.b64encode(xml_file), "order_filename": filename} | ||
| ) | ||
| f.close() |
There was a problem hiding this comment.
Suggested change
| f.close() | |
| root = etree.fromstring(xml_file) | |
| cbc_namespace = root.nsmap.get('cbc') | |
| customer_reference = root.find(f'{{{cbc_namespace}}}CustomerReference').text |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.