Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0][IMP] base_edi: introduce a basic edi user group #33

Open
wants to merge 2 commits into
base: 12.0
Choose a base branch
from

Conversation

thienvh332
Copy link
Owner

@thienvh332 thienvh332 commented Aug 20, 2024

Context

  • The edi_oca module, currently in beta, depends on the base_edi module, which had a development status of alpha. This caused a warning during testing. A recent commit (OCA/edi@e5db4e0) has updated base_edi to beta.
  • Additionally, a basic EDI user group is needed for managing access.

Changes

  • The development status of base_edi has been changed from alpha to beta.
  • Introduced a basic EDI user group for better access control.

@thienvh332 thienvh332 changed the title [IMP] base_edi: introduce a basic edi user group [12.0][IMP] base_edi: introduce a basic edi user group Aug 20, 2024
@thienvh332 thienvh332 force-pushed the 12.0-bprt-base_edi-edi_user branch 2 times, most recently from 5225790 to e9f4ba7 Compare August 20, 2024 08:58
@thienvh332 thienvh332 marked this pull request as ready for review August 21, 2024 03:30
@@ -6,7 +6,7 @@
"name": "Base EDI",
"summary": """Base module to aggregate EDI features.""",
"version": "12.0.1.0.1",
"development_status": "Alpha",
"development_status": "Beta",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what motivates this change?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The edi_oca module has a development_status of "beta" and depends on a module with a development_status of "alpha" and got a warning in test. And in base_edi v14 there is a commit to move it (OCA@e5db4e0)

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's so little that I'll fix it quickly. Or should I cherry-pick it?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep it as is, but make it explicit in PR description why you had to do this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants