Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Svg icon update management #5

Closed
wants to merge 1 commit into from
Closed

Svg icon update management #5

wants to merge 1 commit into from

Conversation

eregnier
Copy link

This change allow icon dom update when symbol binding value changes.
It may be conditionnaly computed, but I don't know at the moment how to define an option to a directive that the update methode would take in account.

thierrymichel added a commit that referenced this pull request Feb 3, 2018
@thierrymichel
✨ 👌 render correctly on update ([pull request #5](#5))
b25bc9f 
✅ add tests
👷 add Travis w/ coverage
📝 add changelog + contributor
🐛 fix expression use + size attribute
@thierrymichel
Copy link
Owner

Hi,

Thanks for pointing this out. 👍
I've fixed this issue in the latest version (v1.2.2).
I also added some test suite and CI for code coverage for the future…

Again, thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eregnier @thierrymichel