Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DepotDownloader as alternative to steamcmd #577

Merged
merged 11 commits into from
Jul 7, 2024

Conversation

sonroyaalmerol
Copy link
Contributor

@sonroyaalmerol sonroyaalmerol commented Jul 5, 2024

Context

There has been a lot of cases where ARM64 users are having trouble with steamcmd in general. The main idea for this PR is to give an alternate way for the container to download game server files without using steamcmd. This should hopefully bring back compatibility with M-series Macs (closes #556).

This will also completely remove the 4k page size limitations we had previously as that was mostly due to steamcmd. (#456, #397)

This should also allow us to go back to using Github hosted runners for the unit tests as long as USE_DEPOT_DOWNLOADER is set to true when executed for ARM64.

Might also help other unrelated steamcmd problems (e.g. #551)

DepotDownloader: https://github.com/SteamRE/DepotDownloader

Choices

We can force ourselves to emulate steamcmd, which has been proven to be very finicky due to the fact that Valve don't ship steamcmd as a 64-bit binary. Or we can go and use open-source tools to download the server files like DepotDownloader.

Test instructions

  1. Set USE_DEPOT_DOWNLOADER to true
  2. Run the container as usual

Checklist before requesting a review

  • I have performed a self-review/test of my code
  • I've added documentation about this change to the docs.
  • I've not introduced breaking changes.
  • My changes do not violate linting rules.

@sonroyaalmerol sonroyaalmerol marked this pull request as ready for review July 5, 2024 02:05
@sonroyaalmerol
Copy link
Contributor Author

@thijsvanloef i'd also appreciate if you could publish a test image tag for this as well so they could easily test 🙏

@thijsvanloef
Copy link
Owner

Here is the image:
thijsvanloef/palworld-server-docker:arm-test

@sonroyaalmerol
Copy link
Contributor Author

This should be good to go :) I'll be working on the other pr as soon as this is merged.

@thijsvanloef thijsvanloef merged commit 1826e29 into thijsvanloef:main Jul 7, 2024
10 checks passed
@sonroyaalmerol sonroyaalmerol deleted the depot-downloader branch July 7, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MacOS Docker Desktop cant run the image
2 participants