-
-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DepotDownloader as alternative to steamcmd #577
Merged
thijsvanloef
merged 11 commits into
thijsvanloef:main
from
sonroyaalmerol:depot-downloader
Jul 7, 2024
Merged
Add DepotDownloader as alternative to steamcmd #577
thijsvanloef
merged 11 commits into
thijsvanloef:main
from
sonroyaalmerol:depot-downloader
Jul 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@thijsvanloef i'd also appreciate if you could publish a test image tag for this as well so they could easily test 🙏 |
4 tasks
Here is the image: |
This should be good to go :) I'll be working on the other pr as soon as this is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
There has been a lot of cases where ARM64 users are having trouble with steamcmd in general. The main idea for this PR is to give an alternate way for the container to download game server files without using steamcmd. This should hopefully bring back compatibility with M-series Macs (closes #556).
This will also completely remove the 4k page size limitations we had previously as that was mostly due to steamcmd. (#456, #397)
This should also allow us to go back to using Github hosted runners for the unit tests as long as
USE_DEPOT_DOWNLOADER
is set to true when executed for ARM64.Might also help other unrelated steamcmd problems (e.g. #551)
DepotDownloader: https://github.com/SteamRE/DepotDownloader
Choices
We can force ourselves to emulate steamcmd, which has been proven to be very finicky due to the fact that Valve don't ship steamcmd as a 64-bit binary. Or we can go and use open-source tools to download the server files like DepotDownloader.
Test instructions
USE_DEPOT_DOWNLOADER
to trueChecklist before requesting a review