Working nav links #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RuairiKerins
force-pushed
the
working-nav-links
branch
from
7828854
to
d1fce9f
Compare
Co-authored-by: Joshua Balloch <joshuaballoch@users.noreply.github.com>
- minor correction class => className
Co-authored-by: Katherine Bowler <katbow@users.noreply.github.com>
…s API - All the content is layered on top of itself need to be fixed up Co-authored-by: Katherine Bowler <katbow@users.noreply.github.com>
Adjust so that the new data structure with the parallax params is supported.
Co-authored-by: Katherine Bowler <katbow@users.noreply.github.com>
Co-authored-by: Katherine Bowler <katbow@users.noreply.github.com>
- Graphql filter - Live data attribute - we could potentially pass this data through better to make the home page.
- Config 1 will throw an error since ref.current is null on page load - Config 2 uses a different approach and will scroll to a given offset
- Height of subheader changes after animation needs a fix Co-authored-by: Joshua Balloch <joshuaballoch@users.noreply.github.com>
Co-authored-by: Joshua Balloch <joshuaballoch@users.noreply.github.com>
RuairiKerins
force-pushed
the
working-nav-links
branch
2 times, most recently
from
56a4c4d
to
f434648
Compare
RuairiKerins
force-pushed
the
working-nav-links
branch
from
f434648
to
fef0351
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.