Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use tedge-container-plugin-ng #43

Merged
merged 17 commits into from
Nov 28, 2024

Conversation

reubenmiller
Copy link
Contributor

@reubenmiller reubenmiller commented Nov 19, 2024

Integrate tedge-container-plugin-ng into the image and use it for all container operations except docker compose actions.

The following are some of the improvements:

  • Compatible with podman >= 4.3 and docker compose >= 18 (using the same container)
  • More verbose logging on container self updates
  • Easier to maintain (golang vs posix shell scripts) and smaller dependencies (it will also allow in the future to pull in docker compose via a container instead of packaging it inside the container)

You can read more about the next-gen tedge-container-plugin here:

Copy link

github-actions bot commented Nov 19, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
16 0 1 16 100 3m47.398272s

Passed Tests

Name ⏱️ Duration Suite
Grace period to allow container to startup 5.048 s Operations
Service is up 0.225 s Operations
Get Logfile Request 4.759 s Operations
Get Configuration File 5.145 s Operations
Execute Shell Command 2.592 s Operations
Install application using docker compose 16.274 s Operations
Get Container Logs 4.775 s Operations
Get Container Logs without explicit container name 2.597 s Operations
Get Container Logs For Non-existent container 2.600 s Operations
Trigger self update via local command 26.405 s Self-Update
Self update should only update if there is a new image 21.907 s Self-Update
Self update using software update operation 106.305 s Self-Update
Rollback when trying to install a non-tedge based image 25.403 s Self-Update
Cloud Connection is Online 0.227 s Telemetry
Service status 0.378 s Telemetry
Sends measurements 2.715 s Telemetry

@reubenmiller reubenmiller force-pushed the feat-update-docker-container-ng branch from 673c811 to 371dd86 Compare November 20, 2024 19:09
@reubenmiller reubenmiller force-pushed the feat-update-docker-container-ng branch from 371dd86 to a11c49e Compare November 22, 2024 12:52
@reubenmiller reubenmiller force-pushed the feat-update-docker-container-ng branch from d1f07ba to 033d209 Compare November 22, 2024 12:55
@reubenmiller reubenmiller force-pushed the feat-update-docker-container-ng branch from 033d209 to 515ce96 Compare November 25, 2024 10:44
@reubenmiller reubenmiller force-pushed the feat-update-docker-container-ng branch from 2f18844 to dab99d2 Compare November 28, 2024 22:16
@reubenmiller reubenmiller marked this pull request as ready for review November 28, 2024 22:25
@reubenmiller reubenmiller added this pull request to the merge queue Nov 28, 2024
Merged via the queue into main with commit f86e668 Nov 28, 2024
7 checks passed
@reubenmiller reubenmiller deleted the feat-update-docker-container-ng branch November 29, 2024 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant