-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: remove usage of actions-rs/toolchain@v1 as it is not actively maintained #1999
Merged
reubenmiller
merged 1 commit into
thin-edge:main
from
reubenmiller:ci/remove-actions-rs-toolchain
Jun 2, 2023
Merged
ci: remove usage of actions-rs/toolchain@v1 as it is not actively maintained #1999
reubenmiller
merged 1 commit into
thin-edge:main
from
reubenmiller:ci/remove-actions-rs-toolchain
Jun 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntained dtolnay/rust-toolchain provides similar functionality, however requires an additional step when using the nightly toolchain because it does not support the override option. Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
reubenmiller
temporarily deployed
to
Test Pull Request
June 1, 2023 11:36 — with
GitHub Actions
Inactive
rina23q
approved these changes
Jun 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I think the reason why we still used actions-rs/toolchain
was exactly for override
. But it's really nice that you found a workaround!
Robot Results
Passed Tests
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Replace the usage of actions-rs/toolchain@v1 as it is no longer maintained and it uses deprecated GitHub Actions API.
The PR switches to using dtolnay/rust-toolchain provides similar functionality, however requires an additional step when using the nightly toolchain because it does not support the override option.
Warning
This does not solve all of the deprecation notices, but reduces any coming from
actions-rs/toolchain@v1
.References
Types of changes
Paste Link to the issue
Checklist
cargo fmt
as mentioned in CODING_GUIDELINEScargo clippy
as mentioned in CODING_GUIDELINESFurther comments
An example of the GitHub deprecated notices are visible from the PR checks run.