Create generic tedge log plugin

[Ruadhri17]

Proposed changes

to do:

• Create tedge_log_plugin
• Replace hardcoded values of topic root and topic identifier with tedge config values

Types of changes

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
• Documentation Update (if none of the other choices apply)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

#2048 and #2017

Checklist

• I have read the CONTRIBUTING doc
• I have signed the CLA (in all commits with git commit -s)
• I ran cargo fmt as mentioned in CODING_GUIDELINES
• I used cargo clippy as mentioned in CODING_GUIDELINES
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

Further comments

[github-actions]

Robot Results

✅ Passed	❌ Failed	⏭️ Skipped	Total	Pass %
251	0	5	251	100

[didier-wenzek]

Since the plan is to deprecate c8y_log_plugin in favor of tedge_log_plugin, I would consider to start these changes with a git mv c8y_log_manager tedge_log_manager. This would help to focus on what is really new. The drawback is that this work will have then a larger scope including c8y-mapper updates and full deprecation of c8y-log-plugin.

This has to be discussed with @rina23q and @reubenmiller

[codecov]

Codecov Report

Merging #2086 (23f0fbd) into main (4ea00b6) will increase coverage by 0.0%.
The diff coverage is 79.2%.

❗ Current head 23f0fbd differs from pull request most recent head f5e2519. Consider uploading reports for the commit f5e2519 to get more accurate results

Additional details and impacted files

Files Changed	Coverage Δ
crates/common/log_manager/src/error.rs	0.0% <ø> (ø)
.../tedge_config/src/tedge_config_cli/tedge_config.rs	87.2% <0.0%> (-1.3%)	⬇️
crates/extensions/c8y_log_manager/src/config.rs	0.0% <ø> (-47.4%)	⬇️
crates/extensions/c8y_log_manager/src/lib.rs	88.7% <ø> (ø)
crates/extensions/tedge_log_manager/src/config.rs	0.0% <0.0%> (ø)
crates/extensions/tedge_log_manager/src/error.rs	0.0% <0.0%> (ø)
plugins/tedge_log_plugin/src/main.rs	0.0% <0.0%> (ø)
crates/extensions/tedge_log_manager/src/actor.rs	75.9% <75.9%> (ø)
crates/common/log_manager/src/config.rs	76.5% <76.5%> (ø)
crates/extensions/c8y_log_manager/src/actor.rs	76.5% <84.6%> (-4.2%)	⬇️
... and 4 more

... and 2 files with indirect coverage changes

[rina23q]

I did a quick sanity review.

[rina23q]

Good job! Some unit tests must be moved and cleaned up to the right place!

[didier-wenzek]

This error case must not be caught as a LogManagementError (send back to the cloud) but lead to a fatal actor error (as the actor peer has been dropped).

Suggested change

	#[error(transparent)]
	FromChannelError(#[from] tedge_actors::ChannelError),

[didier-wenzek]

Okay, the issue is deeper and caused by self.http_proxy.await_response(request).await? mixing channel errors with HTTP errors. This will have to be improved by in a follow-up task.

[didier-wenzek]

I don't see how this can happen (unless the MQTT actor is buggy). Indeed this actor only subscribes to self.config.logfile_request_topic.

[didier-wenzek]

Approved.

[gligorisaev]

QA has thoroughly checked the feature and here are the results:

• Test for ticket exists in the test suite.
• QA has tested the feature and it meets the required specifications.
• Checked the documentation

Test Cases will be created as soon as Installer is existing, that ticket has than to be linked with this one.

[reubenmiller]

Tests are covered by this PR #2213