Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(uninstall): explicitly remove all packages to avoid problems when dependencies are changed #2124

Merged
merged 2 commits into from
Aug 4, 2023
Merged

refactor(uninstall): explicitly remove all packages to avoid problems when dependencies are changed #2124

merged 2 commits into from
Aug 4, 2023

Conversation

reubenmiller
Copy link
Contributor

@reubenmiller reubenmiller commented Aug 3, 2023 •
edited
Loading

Proposed changes

Change the uninstall script to not make any assumptions about the dependencies between thin-edge.io packages. The script already handles the case if the package is not installed, so at worst it is a no-op.

Otherwise, if the dependencies between the packages changes it will not remove all of them.

Integration tests were also added to cover the uninstall script in the current branch, so that any changes to the uninstall script can be validated in the PR before merging to main.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@reubenmiller
refactor(uninstall): explicitly remove all packages to avoid problems…
b730e73 
… when dependencies are changed

Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
@reubenmiller reubenmiller temporarily deployed to Test Pull Request August 3, 2023 21:06 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023 •
edited
Loading

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
241 0 5 241 100

Passed Tests

Name ⏱️ Duration Suite
Prerequisite Parent 15.018 s Child Conf Mgmt Plugin
Prerequisite Child 0.451 s Child Conf Mgmt Plugin
Child device bootstrapping 15.722 s Child Conf Mgmt Plugin
Snapshot from device 61.409 s Child Conf Mgmt Plugin
Child device config update 61.396 s Child Conf Mgmt Plugin
Configuration types should be detected on file change (without restarting service) 58.161 s Inotify Crate
Check lock file existence in default folder 1.758 s Lock File
Check PID number in lock file 1.835 s Lock File
Check PID number in lock file after restarting the services 63.561 s Lock File
Check starting same service twice 1.954 s Lock File
Switch off lock file creation 3.052 s Lock File
Set configuration when file exists 7.752 s Configuration Operation
Set configuration when file does not exist 5.866 s Configuration Operation
Set configuration with broken url 5.896 s Configuration Operation
Get configuration 6.755 s Configuration Operation
Get non existent configuration file 5.696 s Configuration Operation
Get non existent configuration type 5.462 s Configuration Operation
Update configuration plugin config via cloud 5.515 s Configuration Operation
Modify configuration plugin config via local filesystem modify inplace 3.315 s Configuration Operation
Modify configuration plugin config via local filesystem overwrite 5.879 s Configuration Operation
Update configuration plugin config via local filesystem copy 6.556 s Configuration Operation
Update configuration plugin config via local filesystem move (different directory) 4.292 s Configuration Operation
Update configuration plugin config via local filesystem move (same directory) 5.551 s Configuration Operation
Update the custom operation dynamically 64.063 s Dynamically Reload Operation
Custom operation successful 74.394 s Custom Operation
Custom operation fails 68.349 s Custom Operation
Successful firmware operation 131.35 s Firmware Operation
Install with empty firmware name 55.622 s Firmware Operation
Prerequisite Parent 17.422 s Firmware Operation Child Device
Prerequisite Child 8.999 s Firmware Operation Child Device
Child device firmware update 7.205 s Firmware Operation Child Device
Child device firmware update with cache 6.579 s Firmware Operation Child Device
Firmware plugin supports restart via service manager #1932 5.695 s Firmware Operation Child Device Retry
Update Inventory data via inventory.json 1.756 s Inventory Update
Inventory includes the agent fragment with version information 1.5230000000000001 s Inventory Update
Retrieve a JWT tokens 43.389 s Jwt Request
Mapper recovers and processes output of ongoing software update request 17.294 s Recover And Publish Software Update Message
Check running collectd 1.571 s Monitor Device Collectd
Is collectd publishing MQTT messages? 3.219 s Monitor Device Collectd
Check thin-edge monitoring 3.95 s Monitor Device Collectd
Check grouping of measurements 9.567 s Monitor Device Collectd
Main device registration 2.513 s Device Registration
Child device registration 2.759 s Device Registration
Supports restarting the device 63.576 s Restart Device
Update tedge version from previous using Cumulocity 91.348 s Tedge Self Update
Test if all c8y services are up 114.04 s Service Monitoring
Test if all c8y services are down 47.905 s Service Monitoring
Test if all c8y services are using configured service type 116.272 s Service Monitoring
Test if all c8y services using default service type when service type configured as empty 301.839 s Service Monitoring
Check health status of tedge-mapper-c8y service on broker stop start 24.783 s Service Monitoring
Check health status of tedge-mapper-c8y service on broker restart 25.144 s Service Monitoring
Check health status of child device service 20.049 s Service Monitoring
Successful shell command with output 4.386 s Shell Operation
Check Successful shell command with literal double quotes output 3.635 s Shell Operation
Execute multiline shell command 3.708 s Shell Operation
Failed shell command 3.981 s Shell Operation
Software list should be populated during startup 47.797 s Software
Install software via Cumulocity 42.458 s Software
tedge-agent should terminate on SIGINT while downloading file 46.311 s Software
Software list should only show currently installed software and not candidates 48.83 s Software
Create and publish the tedge agent supported operations on mapper restart 43.868 s Mapper-Publishing-Agent-Supported-Ops
Agent gets the software list request once it comes up 30.523 s Mapper-Publishing-Agent-Supported-Ops
Define Child device 1 ID 0.01 s C8Y Child Alarms Rpi
Normal case when the child device does not exist on c8y cloud 2.62 s C8Y Child Alarms Rpi
Normal case when the child device already exists 0.95 s C8Y Child Alarms Rpi
Reconciliation when the new alarm message arrives, restart the mapper 1.341 s C8Y Child Alarms Rpi
Reconciliation when the alarm that is cleared 65.753 s C8Y Child Alarms Rpi
Child devices support sending simple measurements 2.109 s Child Device Telemetry
Child devices support sending custom measurements 1.577 s Child Device Telemetry
Child devices support sending custom events 1.399 s Child Device Telemetry
Child devices support sending custom events overriding the type 1.283 s Child Device Telemetry
Child devices support sending custom alarms #1699 3.536 s Child Device Telemetry
Child devices support sending inventory data via c8y topic 1.177 s Child Device Telemetry
Child device supports sending custom child device measurements directly to c8y 1.9 s Child Device Telemetry
Check retained alarms 219.008 s Raise Alarms
Thin-edge devices support sending simple measurements 1.855 s Thin-Edge Device Telemetry
Thin-edge devices support sending simple measurements with custom type 3.89 s Thin-Edge Device Telemetry
Thin-edge devices support sending custom measurements 1.414 s Thin-Edge Device Telemetry
Thin-edge devices support sending custom events 1.401 s Thin-Edge Device Telemetry
Thin-edge devices support sending custom events overriding the type 1.8010000000000002 s Thin-Edge Device Telemetry
Thin-edge devices support sending custom alarms #1699 1.771 s Thin-Edge Device Telemetry
Thin-edge device supports sending custom Thin-edge device measurements directly to c8y 1.9609999999999999 s Thin-Edge Device Telemetry
Thin-edge device support sending inventory data via c8y topic 1.752 s Thin-Edge Device Telemetry
thin-edge components support a custom config-dir location via flags 26.717 s Config Dir
Validate updated data path used by tedge-agent 0.269 s Data Path Config
Validate updated data path used by c8y-firmware-plugin 10.981 s Data Path Config
Validate updated data path used by tedge-agent 0.294 s Log Path Config
Check existence of init directories 1.015 s Tedge Init
Tedge init and check creation of folders 1.98 s Tedge Init
Check ownership of the folders 1.697 s Tedge Init
Change user/group and check the change 1.687 s Tedge Init
Tedge init and check if default values are restored 2.294 s Tedge Init
Install thin-edge via apt 35.77 s Install Apt
Install latest via script (from current branch) 70.863 s Install Tedge
Install specific version via script (from current branch) 52.256 s Install Tedge
Install latest tedge via script (from main branch) 28.8 s Install Tedge
Install then uninstall latest tedge via script (from main branch) 76.806 s Install Tedge
Support starting and stopping services 48.614 s Service-Control
Supports a reconnect 63.739 s Test-Commands
Supports disconnect then connect 46.772 s Test-Commands
Update unknown setting 35.62 s Test-Commands
Update known setting 50.414 s Test-Commands
It checks MQTT messages using a pattern 82.705 s Test-Mqtt
Stop c8y-configuration-plugin 0.263 s Health C8Y-Configuration-Plugin
Update the service file 0.546 s Health C8Y-Configuration-Plugin
Reload systemd files 0.205 s Health C8Y-Configuration-Plugin
Start c8y-configuration-plugin 0.365 s Health C8Y-Configuration-Plugin
Start watchdog service 10.225 s Health C8Y-Configuration-Plugin
Check PID of c8y-configuration-plugin 0.149 s Health C8Y-Configuration-Plugin
Kill the PID 0.27 s Health C8Y-Configuration-Plugin
Recheck PID of c8y-configuration-plugin 6.6530000000000005 s Health C8Y-Configuration-Plugin
Compare PID change 0.004 s Health C8Y-Configuration-Plugin
Stop watchdog service 0.13 s Health C8Y-Configuration-Plugin
Remove entry from service file 0.137 s Health C8Y-Configuration-Plugin
Stop c8y-log-plugin 0.106 s Health C8Y-Log-Plugin
Update the service file 0.57 s Health C8Y-Log-Plugin
Reload systemd files 0.72 s Health C8Y-Log-Plugin
Start c8y-log-plugin 0.388 s Health C8Y-Log-Plugin
Start watchdog service 10.496 s Health C8Y-Log-Plugin
Check PID of c8y-log-plugin 0.162 s Health C8Y-Log-Plugin
Kill the PID 0.351 s Health C8Y-Log-Plugin
Recheck PID of c8y-log-plugin 6.655 s Health C8Y-Log-Plugin
Compare PID change 0.004 s Health C8Y-Log-Plugin
Stop watchdog service 0.235 s Health C8Y-Log-Plugin
Remove entry from service file 0.239 s Health C8Y-Log-Plugin
Stop tedge-mapper 0.422 s Health Tedge Mapper C8Y
Update the service file 0.247 s Health Tedge Mapper C8Y
Reload systemd files 0.354 s Health Tedge Mapper C8Y
Start tedge-mapper 0.196 s Health Tedge Mapper C8Y
Start watchdog service 10.294 s Health Tedge Mapper C8Y
Check PID of tedge-mapper 0.197 s Health Tedge Mapper C8Y
Kill the PID 0.327 s Health Tedge Mapper C8Y
Recheck PID of tedge-mapper 6.576 s Health Tedge Mapper C8Y
Compare PID change 0.001 s Health Tedge Mapper C8Y
Stop watchdog service 0.226 s Health Tedge Mapper C8Y
Remove entry from service file 0.124 s Health Tedge Mapper C8Y
Stop tedge-agent 0.199 s Health Tedge-Agent
Update the service file 0.134 s Health Tedge-Agent
Reload systemd files 0.662 s Health Tedge-Agent
Start tedge-agent 0.181 s Health Tedge-Agent
Start watchdog service 10.264 s Health Tedge-Agent
Check PID of tedge-mapper 0.112 s Health Tedge-Agent
Kill the PID 0.227 s Health Tedge-Agent
Recheck PID of tedge-agent 6.606 s Health Tedge-Agent
Compare PID change 0.007 s Health Tedge-Agent
Stop watchdog service 0.151 s Health Tedge-Agent
Remove entry from service file 0.234 s Health Tedge-Agent
Stop tedge-mapper-az 0.107 s Health Tedge-Mapper-Az
Update the service file 0.107 s Health Tedge-Mapper-Az
Reload systemd files 0.398 s Health Tedge-Mapper-Az
Start tedge-mapper-az 0.233 s Health Tedge-Mapper-Az
Start watchdog service 10.201 s Health Tedge-Mapper-Az
Check PID of tedge-mapper-az 0.122 s Health Tedge-Mapper-Az
Kill the PID 0.232 s Health Tedge-Mapper-Az
Recheck PID of tedge-agent 6.52 s Health Tedge-Mapper-Az
Compare PID change 0.005 s Health Tedge-Mapper-Az
Stop watchdog service 0.109 s Health Tedge-Mapper-Az
Remove entry from service file 0.164 s Health Tedge-Mapper-Az
Stop tedge-mapper-collectd 0.092 s Health Tedge-Mapper-Collectd
Update the service file 0.301 s Health Tedge-Mapper-Collectd
Reload systemd files 0.368 s Health Tedge-Mapper-Collectd
Start tedge-mapper-collectd 0.169 s Health Tedge-Mapper-Collectd
Start watchdog service 10.196 s Health Tedge-Mapper-Collectd
Check PID of tedge-mapper-collectd 0.177 s Health Tedge-Mapper-Collectd
Kill the PID 0.287 s Health Tedge-Mapper-Collectd
Recheck PID of tedge-mapper-collectd 6.4719999999999995 s Health Tedge-Mapper-Collectd
Compare PID change 0.007 s Health Tedge-Mapper-Collectd
Stop watchdog service 0.291 s Health Tedge-Mapper-Collectd
Remove entry from service file 0.406 s Health Tedge-Mapper-Collectd
tedge-collectd-mapper health status 6.205 s Health Tedge-Mapper-Collectd
c8y-log-plugin health status 5.631 s MQTT health endpoints
c8y-configuration-plugin health status 5.481 s MQTT health endpoints
Publish on a local insecure broker 0.233 s Basic Pub Sub
Publish on a local secure broker 2.234 s Basic Pub Sub
Publish on a local secure broker with client authentication 2.625 s Basic Pub Sub
Publish events to subscribed topic 0.41 s Custom Sub Topics Tedge-Mapper-Aws
Publish measurements to unsubscribed topic 5.435 s Custom Sub Topics Tedge-Mapper-Aws
Publish measurements to subscribed topic 0.319 s Custom Sub Topics Tedge-Mapper-Az
Publish measurements to unsubscribed topic 5.468 s Custom Sub Topics Tedge-Mapper-Az
Publish events to subscribed topic 0.319 s Custom Sub Topics Tedge-Mapper-C8Y
Publish measurements to unsubscribed topic 5.442 s Custom Sub Topics Tedge-Mapper-C8Y
Check remote mqtt broker #1773 6.009 s Remote Mqtt Broker
Apply name filter 0.279 s Filter Packages List Output
Apply maintainer filter 0.266 s Filter Packages List Output
Apply both filters 0.19 s Filter Packages List Output
No filters 0.235 s Filter Packages List Output
Both filters but name filter as empty string 0.169 s Filter Packages List Output
Both filters but maintainer filter as empty string 0.344 s Filter Packages List Output
Both filters as empty string 0.229 s Filter Packages List Output
Wrong package name 0.265 s Improve Tedge Apt Plugin Error Messages
Wrong version 0.156 s Improve Tedge Apt Plugin Error Messages
Wrong type 0.471 s Improve Tedge Apt Plugin Error Messages
tedge_connect_test_positive 0.455 s Tedge Connect Test
tedge_connect_test_negative 1.58 s Tedge Connect Test
tedge_connect_test_sm_services 8.858 s Tedge Connect Test
tedge_disconnect_test_sm_services 1.413 s Tedge Connect Test
Install thin-edge.io 29.705 s Call Tedge
call tedge -V 0.139 s Call Tedge
call tedge -h 0.232 s Call Tedge
call tedge -h -V 0.123 s Call Tedge
call tedge help 0.223 s Call Tedge
tedge config list 0.081 s Call Tedge Config List
tedge config list --all 0.226 s Call Tedge Config List
set/unset device.type 0.535 s Call Tedge Config List
set/unset device.key_path 0.911 s Call Tedge Config List
set/unset device.cert_path 0.61 s Call Tedge Config List
set/unset c8y.root_cert_path 0.39 s Call Tedge Config List
set/unset c8y.smartrest.templates 0.368 s Call Tedge Config List
set/unset c8y.topics 0.528 s Call Tedge Config List
set/unset az.root_cert_path 0.354 s Call Tedge Config List
set/unset az.topics 0.447 s Call Tedge Config List
set/unset aws.topics 0.383 s Call Tedge Config List
set/unset aws.url 0.387 s Call Tedge Config List
set/unset aws.root_cert_path 0.312 s Call Tedge Config List
set/unset aws.mapper.timestamp 0.352 s Call Tedge Config List
set/unset az.mapper.timestamp 0.264 s Call Tedge Config List
set/unset mqtt.bind.address 0.251 s Call Tedge Config List
set/unset mqtt.bind.port 0.258 s Call Tedge Config List
set/unset http.bind.port 0.306 s Call Tedge Config List
set/unset tmp.path 0.308 s Call Tedge Config List
set/unset logs.path 0.299 s Call Tedge Config List
set/unset run.path 0.329 s Call Tedge Config List
set/unset firmware.child.update.timeout 0.257 s Call Tedge Config List
set/unset c8y.url 0.364 s Call Tedge Config List
set/unset az.url 0.377 s Call Tedge Config List
set/unset mqtt.external.bind.port 0.335 s Call Tedge Config List
mqtt.external.bind.address 0.371 s Call Tedge Config List
mqtt.external.bind.interface 0.364 s Call Tedge Config List
set/unset mqtt.external.ca_path 0.364 s Call Tedge Config List
set/unset mqtt.external.cert_file 0.332 s Call Tedge Config List
set/unset mqtt.external.key_file 0.265 s Call Tedge Config List
set/unset software.plugin.default 0.272 s Call Tedge Config List
set/unset apt.name 0.336 s Call Tedge Config List
set/unset apt.maintainer 0.339 s Call Tedge Config List
Get Put Delete 2.181 s Http File Transfer Api
Set keys should return value on stdout 0.094 s Tedge Config Get
Unset keys should not return anything on stdout and warnings on stderr 0.165 s Tedge Config Get
Invalid keys should not return anything on stdout and warnings on stderr 0.188 s Tedge Config Get
Set configuration via environment variables 0.709 s Tedge Config Get
Set configuration via environment variables for topics 0.274 s Tedge Config Get
Set unknown configuration via environment variables 0.123 s Tedge Config Get

@reubenmiller
test(install): verify uninstall script in local branch to validate ch…
de1402e 
…anges before being merged to main

Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
@reubenmiller reubenmiller temporarily deployed to Test Pull Request August 4, 2023 08:06 — with GitHub Actions Inactive
PradeepKiruvale
PradeepKiruvale approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@PradeepKiruvale PradeepKiruvale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reubenmiller reubenmiller merged commit 61a4bc2 into thin-edge:main Aug 4, 2023
@reubenmiller reubenmiller deleted the refactor-uninstall-script branch August 4, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PradeepKiruvale PradeepKiruvale PradeepKiruvale approved these changes

Assignees
No one assigned
Labels
improvement User value theme:installation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reubenmiller @PradeepKiruvale