Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a converter that bridges the old MEA topics to the new ones #2125

Merged

Conversation

PradeepKiruvale
Copy link
Contributor

Proposed changes

This new actor translates the tedge/# topics to te/# topics.

tedge topic te topic other updates
tedge/measurements te/device/main///m/
tedge/measurements/child te/device/child///m/
tedge/alarms/severity/alarm_type te/device/main///a/alarm_type add severity into payload
tedge/alarms/severity/child/alarm_type te/device/child///a/alarm_type add severity into payload
tedge/events/event_type te/device/main///e/event_type
tedge/events/child/event_type te/device/child///e/event_type
tedge/health/service-name te/device/main/service/service-name/status/health
tedge/health/child/service-name te/device/child/service/service-name/status/health

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

#2079

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #2125 (ad7f57c) into main (ab4e078) will increase coverage by 0.2%.
Report is 7 commits behind head on main.
The diff coverage is 81.4%.

❗ Current head ad7f57c differs from pull request most recent head ffc81cd. Consider uploading reports for the commit ffc81cd to get more accurate results

Additional details and impacted files
Files Changed Coverage Δ
crates/core/tedge_agent/src/agent.rs 0.0% <0.0%> (ø)
crates/core/tedge_agent/src/main.rs 0.0% <ø> (ø)
...tedge_agent/src/tedge_to_te_converter/converter.rs 85.1% <85.1%> (ø)
...ore/tedge_agent/src/tedge_to_te_converter/tests.rs 89.2% <89.2%> (ø)

... and 2 files with indirect coverage changes

crates/core/tedge_agent/src/tedge_to_te_converter/actor.rs Outdated Show resolved Hide resolved
crates/core/tedge_agent/src/tedge_to_te_converter/actor.rs Outdated Show resolved Hide resolved
crates/core/tedge_agent/src/tedge_to_te_converter/actor.rs Outdated Show resolved Hide resolved
crates/core/tedge_agent/src/tedge_to_te_converter/actor.rs Outdated Show resolved Hide resolved
crates/core/tedge_agent/src/tedge_to_te_converter/actor.rs Outdated Show resolved Hide resolved
crates/core/tedge_agent/src/tedge_to_te_converter/actor.rs Outdated Show resolved Hide resolved
crates/core/tedge_agent/src/tedge_to_te_converter/actor.rs Outdated Show resolved Hide resolved
crates/core/tedge_agent/src/tedge_to_te_converter/actor.rs Outdated Show resolved Hide resolved
crates/core/tedge_agent/src/tedge_to_te_converter/error.rs Outdated Show resolved Hide resolved
crates/core/tedge_agent/src/agent.rs Outdated Show resolved Hide resolved
@PradeepKiruvale PradeepKiruvale temporarily deployed to Test Pull Request August 8, 2023 07:12 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
247 0 5 247 100

@PradeepKiruvale PradeepKiruvale temporarily deployed to Test Pull Request August 8, 2023 15:16 — with GitHub Actions Inactive
Copy link
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. This is close to be merged. I only have some concerns for the duplicated Alarm struct.

crates/core/tedge_agent/Cargo.toml Outdated Show resolved Hide resolved
crates/core/tedge_agent/src/tedge_to_te_converter/error.rs Outdated Show resolved Hide resolved
crates/core/tedge_agent/src/tedge_to_te_converter/error.rs Outdated Show resolved Hide resolved
crates/core/tedge_agent/src/agent.rs Outdated Show resolved Hide resolved
@PradeepKiruvale PradeepKiruvale temporarily deployed to Test Pull Request August 9, 2023 02:15 — with GitHub Actions Inactive
@didier-wenzek didier-wenzek temporarily deployed to Test Pull Request August 9, 2023 09:09 — with GitHub Actions Inactive
Signed-off-by: Pradeep Kumar K J <pkj@softwareag.com>
@PradeepKiruvale PradeepKiruvale marked this pull request as ready for review August 9, 2023 10:25
@PradeepKiruvale PradeepKiruvale temporarily deployed to Test Pull Request August 9, 2023 10:33 — with GitHub Actions Inactive
Copy link
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants