Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(install): improve reliability of latest version detection by using non rate limited api #2129

Merged
merged 1 commit into from
Aug 4, 2023
Merged

fix(install): improve reliability of latest version detection by using non rate limited api #2129

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 9 additions & 11 deletions get-thin-edge_io.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,23 +244,21 @@ install_tedge_plugins() {
}

get_latest_version() {
# Detect latest version from github api to avoid having a default version in the script
# Detect latest version from github using api to avoid having a default version in the script
# The request checks the redirected url behind the latest url.
# Example:
# https://github.com/thin-edge/thin-edge.io/releases/latest => https://github.com/thin-edge/thin-edge.io/releases/tag/0.12.0
#
# Note: avoid using the api endpoint (api.github.com) as it is rate limited for unauthenticated requests.
if command_exists curl; then
response=$(curl -s https://api.github.com/repos/thin-edge/thin-edge.io/releases/latest)
response=$(curl -Ls -o /dev/null -w "%{url_effective}" 'https://github.com/thin-edge/thin-edge.io/releases/latest')
elif command_exists wget; then
response=$(wget -q --output-document - https://api.github.com/repos/thin-edge/thin-edge.io/releases/latest)
response=$(wget --max-redirect=0 https://github.com/thin-edge/thin-edge.io/releases/latest 2>&1 | awk '/Location: /,// { print }' | awk '{print $2}')
else
fail 1 "Detecting latest version requires either curl or wget to be installed"
fi

# use the same url pattern as expected when downloading the artifacts (so as not to rely on github api response fields)
version=$(
echo "$response" \
| grep -o "https://github.com/thin-edge/thin-edge.io/releases/download/[0-9]\+\.[0-9]\+\.[0-9]\+/.*\.deb" \
| grep -o "/[0-9]\+.[0-9]\+.[0-9]\+/" \
| cut -d/ -f2 \
| head -1
)
version=$(echo "$response" | rev | cut -d/ -f1 | rev)

if [ -z "$version" ]; then
fail 1 "Failed to detect latest version. You can try specifying an explicit version. Check the help for more details"
Expand Down