-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: extended linux package support #2138
Conversation
configuration/package_scripts/templates/apk/postinst-systemd-enable
Outdated
Show resolved
Hide resolved
The integration tests needed to be triggered manually due to a change in the workflow, the integration test result is visible here: https://github.com/thin-edge/thin-edge.io/actions/runs/5808419548 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
just release
produces the expected packages.- The integration tests are green (when launched manually).
cb44875
to
feedcf3
Compare
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
feedcf3
to
aa33154
Compare
Codecov Report
Additional details and impacted files |
The integration tests were manually triggered on the server and the results are viewable here: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirm my approval.
The tests are green : https://github.com/thin-edge/thin-edge.io/actions/runs/5822207126/job/15786757181
Proposed changes
Add support for the following linux packages:
Try out the new installation method (for test purposes only)
Packages for armv7, aarch64 and x86_64 were published to a development repository to test out the new installation script. You can test it out for yourself using the following command:
curl -fsSL https://thin-edge.io/install.sh | sudo sh -s
If you don't have sudo installed and are running it as root, then you can drop the sudo part.
curl -fsSL https://thin-edge.io/install.sh | sh -s
Key Changes
tedge-full
andtedge-minimal
) to make it easier for users to install all the thin-edge.io components (and make future renaming of some packages much easier)install.sh
script which installs thin-edge.io from the Cloudsmith repositories and falls back to installing the tarballs if no package manager is found (though currently it only installs the latest version, and can't be used to install a specific version)Note
Currently the integration tests (tests/RobotFramework/tests/installation/install_on_linux.robot) which test the installation using the
install.sh
script are not run automatically. The tests can be run on demand during QA. This is because the tests require the packages to be already published to the cloudsmith repo. In addition some docker related networking issues seem to cause the tests to be unreliable.Minor changes
pre-depends
dependency as it is harder to maintain across different package formats and is generally less flexiblec8y-bridge.conf
file existed.Types of changes
Paste Link to the issue
Checklist
cargo fmt
as mentioned in CODING_GUIDELINEScargo clippy
as mentioned in CODING_GUIDELINESFurther comments