Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tedge plugin specs after c8y-mapper change #2216

Merged
merged 3 commits into from
Sep 4, 2023
Merged

Update tedge plugin specs after c8y-mapper change #2216

merged 3 commits into from
Sep 4, 2023

Conversation

rina23q
Copy link
Member

@rina23q rina23q commented Sep 4, 2023 •
edited
Loading

Proposed changes

See the comment here. #2108 (comment)

During the work of c8y-mapper, we decided to use the device name inside tedgeUrl instead of using "main". So, this PR updates the specs to align with the implementation.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

#2048

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@rina23q
Update tedge plugin specs after c8y-mapper change
2b1560e 
tedgeUrl is now using the device name instead of "main" for the main
device. This change is made on the PR thin-edge#2108.

Signed-off-by: Rina Fujino <18257209+rina23q@users.noreply.github.com>
@rina23q rina23q mentioned this pull request Sep 4, 2023
Closed
6 tasks
@rina23q @didier-wenzek
Apply suggestions from code review
d4c0e39 
Co-authored-by: Didier Wenzek <didier.wenzek@free.fr>
rina23q
rina23q commented Sep 4, 2023
View reviewed changes
Copy link
Member Author

@rina23q rina23q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add suggestions from Didier

docs/src/references/tedge-configuration-management.md Outdated Show resolved Hide resolved
docs/src/references/tedge-configuration-management.md Outdated Show resolved Hide resolved
didier-wenzek
didier-wenzek approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@rina23q rina23q temporarily deployed to Test Pull Request September 4, 2023 13:08 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
261 0 5 261 100 59m50.575s

@rina23q rina23q merged commit 3670bdf into thin-edge:main Sep 4, 2023
@rina23q rina23q deleted the doc/update-tedge-log-plugin-spec branch September 4, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@didier-wenzek didier-wenzek didier-wenzek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rina23q @didier-wenzek